It would be nice to have all class properties defined at the top of the class with a type hint next to each one.

I don’t know if IDE can format arrays the way you have and it may get difficult to maintain.

I’d suggest following commonly agreed formatting, I.e.

I had a quick run through, those are just some of my notes If game.game_won = True or game.game_winning_outcome = 'Draw': Print(f' Player 1 marker: choose a position: ')) Print('You didnt chose a valid marker try again!') While marker_player_1 not in game_markers: Print(' Player 1 choose between markers X or O')

# Game beggining who plays first and markers attribution _other_player.look_adversary_position(new_position) New_position = self._board.mark_board(_mark, position) Self.game_winning_outcome = player.marker Print('Player', player.marker, 'has won') If set(w).issubset(player.owned_positions): Self._player_time = (self._player_time + 1) % 2ĭef _check_winning_condition(self, player):

Self.avaliable_positions = avaliable_positionsĭef choose_first_player(self, first_player: int): Self.adversary_positions.append(position)ĭef look_game_board(self, avaliable_positions): Self.avaliable_positions.remove(position)ĭef _init_(self, marker, first_play = False):Īssert marker in, f'Marker not allowed'ĭef look_adversary_position(self, position): Position = int(input('Invalid move, choose another position ')) Temp = self._render_row_state(r, self.markers)Įlif position not in self.positions or position not in self.avaliable_positions: import reĭef _render_row_state(self, row, marker):

I would like to know if my code has a lot of repetition and if it could have been done in a shorter, cleaner, faster, more efficient and more elegant way.

As someone that started to learn basic python programming, I decided to make a Python tic-tac-toe game for the terminal, to develop my OOP skills.

Make your own travel tic tac toe